Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: workaround pin clap version to 3.1 or there are inappropriate lint errors: https://github.com/clap-rs/clap/issues/3822 #374

Merged
merged 1 commit into from
Jun 15, 2022
Merged

CI: workaround pin clap version to 3.1 or there are inappropriate lint errors: https://github.com/clap-rs/clap/issues/3822 #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion openraft/Cargo.toml
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ futures = "0.3"
maplit = "1.0.2"
rand = "0.8"
serde = { version="1", features=["derive", "rc"], optional = true}
clap = { version = "3.0.7", features = ["derive", "env"] }
clap = { version = "~3.1", features = ["derive", "env"] }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice you are!
Thanks!

thiserror = "1.0.29"
tokio = { version="1.8", default-features=false, features=["fs", "io-util", "macros", "rt", "rt-multi-thread", "sync", "time"] }
tracing = "0.1.29"
Expand Down