Add two tests that document portability issues of run-records #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adswa
reviewed
Oct 19, 2023
mih
force-pushed
the
runpatch
branch
2 times, most recently
from
dfcb669
to
a77f06b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 92.41% 92.37% -0.05%
==========================================
Files 126 125 -1
Lines 9577 9611 +34
Branches 1036 1038 +2
==========================================
+ Hits 8851 8878 +27
- Misses 704 711 +7
Partials 22 22
☔ View full report in Codecov by Sentry. |
- IO specifications are stored in platform-native conventions - IO specifications are reported as-is combined with the absence of any platform type record, this makes run-records non-portable across unix/windows scopes. Ping datalad/datalad#7512
There is limited support for reading and acting on old run-records that have paths stored in platform conventions. Detection works when the path matching an existing item on the file system. Paths are always stored in POSIX notation, whenever they are relative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combined with the absence of any platform type record, this makes run-records non-portable across unix/windows scopes.
Ping datalad/datalad#7512
TODO
windows(not tonative). This could/would be considered for reading (rerun) AND writing (run). If incoming paths are incompatible with the setting (e.g., absolute windows path and a POSIX setting), an error would be issued.