Atomic UrlOperations.upload for ssh- and file-URLs #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-monch
changed the title
christian-monch
changed the title
christian-monch
force-pushed
the
atomic-upload
branch
4 times, most recently
from
0c248eb
to
8c7fc58
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 92.47% 93.10% +0.62%
==========================================
Files 183 171 -12
Lines 12346 11992 -354
Branches 1890 1809 -81
==========================================
- Hits 11417 11165 -252
+ Misses 727 639 -88
+ Partials 202 188 -14 ☔ View full report in Codecov by Sentry. |
This commit fixes the arguments to `UrlOperationsRessourceUnknown` and `UrlOperationsRemoteError` in `FileUrlOperations.upload()`. A regression test for `UrlOperationsRemoteError` is added as well.
This commit adds an atomic upload for files. This can prevent errors where two threads are writing to the same file concurrently.
christian-monch
force-pushed
the
atomic-upload
branch
from
8c7fc58
to
407abfb
Compare
This commit adds return statements to the methods `FileUrlOperations.delete` and `FileUrlOperations.upload` to ensure that the expected return types are in fact returned in all cases, instead of returning `None`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue datalad-ria #102 and touches on issue #454 where atomic upload operations are discussed as well.
The PR also adds atomic upload to files. This can prevent data loss in the case where two threads write to the same file concurrently.
All ssh- and file-uploads should be atomic, which means an
atomic-parameter that controls atomicity on a per-call basis is not necessary.