Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF(DOC): workaround for #10701 of sphinx in 5.1.0 #6883

Merged
merged 1 commit into from Jul 24, 2022

Conversation

yarikoptic
Copy link
Member

See sphinx-doc/sphinx#10701 for more information.
I have not checked if rendered docs are anyhow affected etc. I hope the issue
would get fixed asap since should affect lots of sphinx users

Fixes #6882

See sphinx-doc/sphinx#10701 for more information.
I have not checked if rendered docs are anyhow affected etc. I hope the issue
would get fixed asap since should affect lots of sphinx users
@codeclimate
Copy link

codeclimate bot commented Jul 24, 2022

Analysis results are not available for those commits

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #6883 (c7ba04e) into maint (cefecae) will increase coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            maint    #6883      +/-   ##
==========================================
+ Coverage   90.25%   90.56%   +0.30%     
==========================================
  Files         354      354              
  Lines       46113    46540     +427     
==========================================
+ Hits        41621    42150     +529     
+ Misses       4492     4390     -102     
Impacted Files Coverage Δ
datalad/ui/utils.py 50.00% <0.00%> (-19.45%) ⬇️
datalad/metadata/extractors/tests/test_base.py 87.80% <0.00%> (-12.20%) ⬇️
datalad/support/archive_utils_patool.py 29.87% <0.00%> (-10.39%) ⬇️
datalad/local/tests/test_wtf.py 90.47% <0.00%> (-8.34%) ⬇️
datalad/api.py 86.66% <0.00%> (-8.08%) ⬇️
datalad/metadata/extractors/tests/test_xmp.py 92.59% <0.00%> (-7.41%) ⬇️
datalad/support/cookies.py 80.88% <0.00%> (-7.36%) ⬇️
datalad/core/local/tests/test_results.py 92.85% <0.00%> (-7.15%) ⬇️
datalad/downloaders/tests/test_http.py 87.76% <0.00%> (-6.59%) ⬇️
datalad/cli/main.py 76.00% <0.00%> (-6.00%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cefecae...c7ba04e. Read the comment docs.

@yarikoptic yarikoptic added the semver-documentation Changes only affect the documentation, no impact on version label Jul 24, 2022
@yarikoptic
Copy link
Member Author

uff -- why did I submit it against master? let's try to change base

@yarikoptic yarikoptic changed the base branch from master to maint July 24, 2022 20:02
@yarikoptic yarikoptic requested a review from mih July 24, 2022 20:02
Copy link
Member

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging through this issue. I would be fine with such a patch, and the docs are happy again.

@yarikoptic
Copy link
Member Author

yarikoptic commented Jul 24, 2022

coolio, thank you @adswa ! Let's merge and I will push a merge to master (edit: done in 1ccf796)

@yarikoptic yarikoptic merged commit 798686d into datalad:maint Jul 24, 2022
@yarikoptic yarikoptic deleted the bf-sphinx-5.1.0 branch October 14, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-documentation Changes only affect the documentation, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTBFS docs: sphinx 5.1.0 "pop from an empty deque"
2 participants