Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm@6.11 in CircleCI config to fix broken build from git dependencies #222

Closed
wants to merge 20 commits into from

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Sep 24, 2019

Fixes #221.

Related PR https://github.com/datavisyn/dTiles/pull/210

Summary

Next steps

  • Our Docker build image caleydo/phovea_circleci_python:v2.0 installs node 8.x, which resolves to node@8.14.0 and npm@6.4.1
  • Instead of installing npm@6.11 with every CircleCI build we should rather install the version directly in our Docker build image and release it as caleydo/phovea_circleci_python:v3.0
  • Afterwards we must update all our CircleCI configs to caleydo/phovea_circleci_python:v3.0

@thinkh
Copy link
Member Author

thinkh commented Sep 24, 2019

@lehnerchristian and @dg-datavisyn Could you please run node -v and npm -v and post your local versions here for comparison? I'd like to compare the versions, because I'm still wondering why usually locally everything works well, but it results in CircleCI build errors.

@thinkh thinkh added the type: bug Something isn't working label Sep 24, 2019
@lehnerchristian
Copy link

I use node@8.15.0 and npm@6.4.1

@lehnerchristian
Copy link

but I'll update npm locally

@thinkh
Copy link
Member Author

thinkh commented Sep 26, 2019

After testing the different npm versions it seems that npm@6.6.0 is working. Looking at the release notes it contains a fix that handles git branch references correctly.

@thinkh
Copy link
Member Author

thinkh commented Sep 26, 2019

Following the release notes npm@6.9.0 solves git dependencies with #semver: don’t seem to resolve and dedup correctly, which might be relevant for us since we are using semver ranges in for git branches.

What I Wanted to Do
If you use ssh+git://url#semver: in two different projects, they won’t dedup unless the versions specified in the #semver: is exactly the same.

What Happened Instead
Two identical copies of a module is installed. even ‘npm dedup’ does not remove the copy

@thinkh thinkh changed the title Use npm@6.11.3 in CircleCI config to fix broken build from git dependencies Use npm@6.11 in CircleCI config to fix broken build from git dependencies Sep 26, 2019
@thinkh
Copy link
Member Author

thinkh commented Oct 14, 2019

We (@anita-steiner, @dg-datavisyn, and @lehnerchristian) agreed in a personal meeting that we will test and update to Node 12 LTS (see phovea/generator-phovea#191), which includes npm@6.11.

@thinkh
Copy link
Member Author

thinkh commented Nov 18, 2019

The next generator release uses Node.js v12. After updating the CircleCI config to the new version, we this issue should be fixed.

# Conflicts:
#	package-lock.json
#	package.json
Use the config template from generator-phovea v2.0.1
@thinkh
Copy link
Member Author

thinkh commented Nov 22, 2019

Close this PR and open a new (clean) PR instead.

See PR #255.

@thinkh thinkh closed this Nov 22, 2019
@thinkh thinkh deleted the thinkh/221_use-phovea-clue-develop-branch branch December 2, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants