Remove Vis ranking listeners #715
Draft
+29
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oltionchampari
added
type: bug
|
@dvzacharycutler @oltionchampari Please finish this PR, as it causes performance issues if using the application for too long. In general, the problem is that the listeners are always added, however never removed, such that events are triggered multiple times (including the render). |
|
@dvzacharycutler @oltionchampari See my comment above, I think this is still relevant? |
|
@puehringer I am not sure what is there still to do here apart from some testing, this looks already good to me? |
|
@oltionchampari There is still the TODO mentioning the unique ids which is bug right now, so there is still something left to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for now, will investigate further and test with multiple Vis Panels / rankings