Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call select2 as it is a AMD module #876

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: call select2 as it is a AMD module #876

merged 1 commit into from
Mar 7, 2024

Conversation

puehringer
Copy link
Contributor

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 馃

@puehringer puehringer requested a review from a team as a code owner March 7, 2024 10:13
@puehringer puehringer requested a review from thinkh March 7, 2024 10:13
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this branch in Ordino and it restores the original Select2 functionality in the rspack branch.

grafik

@thinkh thinkh merged commit b4f3a7c into develop Mar 7, 2024
4 checks passed
@thinkh thinkh deleted the mp/select2 branch March 7, 2024 10:57
@thinkh thinkh mentioned this pull request Mar 7, 2024
thinkh added a commit that referenced this pull request Mar 7, 2024
## What's Changed

* fix: call select2 as it is a AMD module by @puehringer in
#876

**Full Changelog**:
v25.0.0...v25.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants