Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lineup): override lineup sorting icons #878

Merged
merged 3 commits into from
Apr 29, 2024
Merged

feat(lineup): override lineup sorting icons #878

merged 3 commits into from
Apr 29, 2024

Conversation

dvdanielamoitzi
Copy link
Contributor

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 馃

@dvdanielamoitzi dvdanielamoitzi changed the base branch from main to develop April 29, 2024 11:38
@dvdanielamoitzi dvdanielamoitzi marked this pull request as ready for review April 29, 2024 11:38
@dvdanielamoitzi dvdanielamoitzi requested a review from a team as a code owner April 29, 2024 11:38
thinkh
thinkh reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You only need to check the indentation of the new CSS rules.

src/scss/vendors/_lineup.scss Outdated Show resolved Hide resolved
src/scss/vendors/_lineup.scss Outdated Show resolved Hide resolved
@thinkh thinkh self-assigned this Apr 29, 2024
@thinkh thinkh added type: feature New feature or request release: patch PR merge results in a new patch version labels Apr 29, 2024
@thinkh thinkh changed the title feat: override lineup sorting icons feat(lineup): override lineup sorting icons Apr 29, 2024
@thinkh thinkh merged commit 274d89a into develop Apr 29, 2024
4 checks passed
@thinkh thinkh deleted the dmoitzi/add-new-sorting-icons branch April 29, 2024 12:00
@dvvanessastoiber dvvanessastoiber mentioned this pull request Apr 29, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
release: patch PR merge results in a new patch version type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvdanielamoitzi @thinkh