Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: remove @storybook/addon-mdx-gfm as it breaks the build #68

Merged
merged 5 commits into from Apr 24, 2024
Merged

deps: remove @storybook/addon-mdx-gfm as it breaks the build #68

merged 5 commits into from Apr 24, 2024

Conversation

puehringer
Copy link
Contributor

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Removes deprecated addon which breaks the build currently:
  ➤ YN0001: │ Error: @storybook/node-logger@workspace:*: Workspace not found (@storybook/node-logger@workspace:*)

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer requested a review from a team as a code owner April 23, 2024 18:29
@puehringer
Copy link
Contributor Author

puehringer commented Apr 23, 2024 •
edited

@dvdanielamoitzi Could you test this PR with your storybook changes (i.e. docs and stuff)? Because if that works, we can safely assume that we are good to go.

EDIT: I tested storybook w/ visyn_pro and everything works as expected. 👍

@puehringer puehringer merged commit c4de26f into develop Apr 24, 2024
1 check passed
@puehringer puehringer deleted the mp/storybook_fix branch April 24, 2024 06:45
@puehringer puehringer added release: patch PR merge results in a new patch version dependencies Pull requests that update a dependency file labels Apr 24, 2024
@dvvanessastoiber dvvanessastoiber mentioned this pull request Apr 24, 2024
Merged
puehringer added a commit that referenced this pull request Apr 24, 2024
@puehringer
Release 8.0.3 (#70)
8c1563e 
## What's changed

* fix: add sassOptions.outputStyle to expanded in rspack.config.js
(#65)
* deps: remove @storybook/addon-mdx-gfm as it breaks the build
(#68)
* feat: allow setting devtool=false
(#69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

@dvdanielamoitzi dvdanielamoitzi Awaiting requested review from dvdanielamoitzi

Assignees

@thinkh thinkh

@dvdanielamoitzi dvdanielamoitzi

Labels
dependencies Pull requests that update a dependency file release: patch PR merge results in a new patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puehringer @thinkh @dvdanielamoitzi