Don't skip start date in weekend check

date-fns · Sep 6, 2019 · ac802b2 · ac802b2
1 parent 8ad51a2
commit ac802b2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/eachWeekendOfInterval/index.js b/src/eachWeekendOfInterval/index.js
@@ -39,8 +39,8 @@ export default function eachWeekendOfInterval(interval) {
   var dateInterval = eachDayOfInterval(interval)
   var weekends = []
   var index = 0
-  while (index++ < dateInterval.length) {
-    var date = dateInterval[index]
+  while (index < dateInterval.length) {
+    var date = dateInterval[index++]
     if (isWeekend(date)) {
       weekends.push(date)
       if (isSunday(date)) index = index + 5

diff --git a/src/eachWeekendOfInterval/test.js b/src/eachWeekendOfInterval/test.js
@@ -18,6 +18,19 @@ describe('eachWeekendOfInterval', function() {
     ])
   })
 
+  it('returns all weekends within the interval when starting on a weekend', function() {
+    var result = eachWeekendOfInterval({
+      start: new Date(2018, 8 /* Sept */, 22),
+      end: new Date(2018, 8 /* Sept */, 30)
+    })
+    assert.deepEqual(result, [
+      new Date(2018, 8 /* Sept */, 22),
+      new Date(2018, 8 /* Sept */, 23),
+      new Date(2018, 8 /* Sept */, 29),
+      new Date(2018, 8 /* Sept */, 30)
+    ])
+  })
+
   it('throws `RangeError` invalid interval start date is used', function() {
     // $ExpectedMistake
     var block = eachWeekendOfInterval.bind(null, {