Make lightFormat throw RangeError if the time value is invalid

date-fns · Jan 9, 2019 · d9f629a · d9f629a
1 parent a31b612
commit d9f629a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/lightFormat/index.js b/src/lightFormat/index.js
@@ -92,7 +92,7 @@ export default function lightFormat(dirtyDate, dirtyFormatStr) {
   var originalDate = toDate(dirtyDate)
 
   if (!isValid(originalDate)) {
-    return 'Invalid Date'
+    throw new RangeError('Invalid time value')
   }
 
   // Convert the date in system timezone to the same date in UTC+00:00 timezone.

diff --git a/src/lightFormat/test.js b/src/lightFormat/test.js
@@ -109,8 +109,11 @@ describe('lightFormat', () => {
     })
   })
 
-  it("returns String('Invalid Date') if the date isn't valid", () => {
-    assert(lightFormat(new Date(NaN), 'MMMM d, yyyy') === 'Invalid Date')
+  it("throws RangeError if the date isn't valid", () => {
+    assert.throws(
+      lightFormat.bind(null, new Date(NaN), 'MMMM d, yyyy'),
+      RangeError
+    )
   })
 
   it('implicitly converts `formatString`', () => {