Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getWeekOfMonth() with options.weekStartsOn set to 1 doesn't work for Sundays #1040

Closed
daandvs opened this issue Jan 14, 2019 · 3 comments
Closed

getWeekOfMonth() with options.weekStartsOn set to 1 doesn't work for Sundays #1040

daandvs opened this issue Jan 14, 2019 · 3 comments
Labels
🐛 Bug

Comments

@daandvs
Copy link

daandvs commented Jan 14, 2019

When executing getWeekOfMonth(new Date(2019, 4, 5), { weekStartsOn: 1 }) it returns me 2 while I expect it to be 1.
It seems getWeekOfMonth() is always a week off when executed with a day set to Sunday and options.weekStartsOn set to > 0.
@waseemahmad31
Copy link
Contributor

This seems to an issue. I also have reproduced this. Can I work on this?

@waseemahmad31 waseemahmad31 mentioned this issue Jan 19, 2019
Merged
@kossnocorp
Copy link
Member

Thank for reporting it!

@laurentsenta laurentsenta mentioned this issue Aug 11, 2019
Closed
@leshakoss
Copy link
Contributor

Fixed in #1046 and released as v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kossnocorp @leshakoss @daandvs @waseemahmad31