Accept abbreviated march, june, july in Norwegian locales #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Norwegian locale currently prints out abbreviated months as 3 letters and a dot except for march, june and july that is printed out in full without a dot. (I assume this to ensure the abbreviated month character count is always 4?)
The parsing regexes currently don't reflect this, resulting in invalid dates.
This small fix aims to ammend that, so that parsing still works for these date formats. Same issue in both Norsk Bokmål (nb) and Nynorsk (nn) included in this fix