Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix march in Dutch parsing patterns #1433

Merged

Conversation

lovelovedokidoki
Copy link
Contributor

Small change. Most of this PR is just automatic prettifying of the code.
Changed /^mrt/i -> /^m(r|a)/i to support parsing both wide form (maart) and abbreviated form (mrt) of march in Dutch.

There were no affected examples in the Dutch snapshot, but dates containing "maart" fail parsing without this change. This bug was caught by running a format-parse rountrip unit test similar to the one in #1423

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants