Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change "rounding" explanation to "truncate" #2050

Closed
wants to merge 1 commit into from

Conversation

wjhsf
Copy link

@wjhsf wjhsf commented Oct 26, 2020

Docs for add / sub functions say "Positive decimals will be rounded using Math.floor, decimals less than zero will be rounded using Math.ceil."

Docs for differenceInDays / differenceInWeeks say "Fractional days/weeks are truncated towards zero."

This PR changes the add / sub docs to use the latter, as it is more clear and concise.

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you a lot!

@tan75
Copy link
Contributor

tan75 commented Oct 2, 2021

hi @wjhsf
unfortunately, I will have to close this PR as the doc files have been changed in one of our latest PRs #2571

@tan75 tan75 closed this Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants