Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS locale now using time seconds, not arc seconds #2457

Closed
wants to merge 2 commits into from

Conversation

march08
Copy link

@march08 march08 commented Apr 30, 2021

Hey guys, just noticed there is bad wording used for CS locale

Currently word vteřina is being used, HOWEVER. Vteřina is a word for arc second, not time second.
For time second, sekunda is the correct word to use

See: https://cs.wikipedia.org/wiki/Vte%C5%99ina

edit:
resolves #1488

@march08 march08 changed the title cs locale use time seconds, not arc seconds CS locale now using time seconds, not arc seconds Apr 30, 2021
@march08
Copy link
Author

march08 commented Jun 1, 2021

Anyone here who can help with the review?

@tan75 tan75 self-assigned this Jun 4, 2021
@tan75
Copy link
Contributor

tan75 commented Jun 4, 2021

hi @march08
Apologies for the delay!
The changes you made in your PR seem to be correct however I cant submit Github actions jobs for some reason as it is giving me an error - I am not sure what is going on.
As well, I noticed you didn't commit a new locale snapshot.
Could you please run from the command line yarn locale-snapshots and push up the results (snapshot.md file)?
This new commit might trigger the GH workflow again so I would be able to approve this PR.
Many thanks!

Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please push up a locale snapshot

@leshakoss
Copy link
Contributor

Hi, thanks a lot for your PR! We merged this fix in #2577

@leshakoss leshakoss closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Czech translation
3 participants