add new function roundToNearestHours #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakamossan
force-pushed
the
928-round-to-nearest-hours
branch
from
59e54a2
to
9f4f88a
Compare
|
ref #3132 |
sakamossan
force-pushed
the
928-round-to-nearest-hours
branch
2 times, most recently
from
d4aaac4
to
b31cdf8
Compare
|
Hello. It's been a while since I created the pull request, but I caught up changes with v3. |
|
Hey, I'm back! Let me catch up with everything and I'll help you land the PR. |
kossnocorp
reviewed
Mar 5, 2024
src/roundToNearestHours/index.ts
Outdated
| import { getRoundingMethod } from "../_lib/getRoundingMethod/index.js"; | ||
| import { constructFrom } from "../constructFrom/index.js"; | ||
| import { toDate } from "../toDate/index.js"; | ||
| import type { NearestHoursOptions, RoundingOptions } from "../types"; |
There was a problem hiding this comment.
Suggested change
| import type { NearestHoursOptions, RoundingOptions } from "../types"; | |
| import type { NearestHoursOptions, RoundingOptions } from "../types.js"; |
kossnocorp
force-pushed
the
928-round-to-nearest-hours
branch
from
b31cdf8
to
a923d47
Compare
Added `roundToNearestHours` function.
kossnocorp
force-pushed
the
928-round-to-nearest-hours
branch
from
a923d47
to
e02e078
Compare
|
Shipped with |
|
I'm not sure if this is intentional but this function can't be imported like Seems like it just needs the file included in the root index file. Happy to make a PR if that is desired. |
|
@monsonjeremy Thanks for reporting! I've tested this in v3.6.0, and it seems the issue has been resolved. $ node --input-type=module -e '
import { roundToNearestHours } from "date-fns";
console.log(roundToNearestHours(new Date()))
'
2024-04-25T02:00:00.000ZEnvironment$ node --version
v18.13.0
$ cat package.json | jq -c .dependencies
{"date-fns":"^3.6.0"}Please let me know if my confirmation is not what you expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #787 #928
Added
roundToNearestHours, which is similar toroundToNearestMinutes.If this is the right way to contribute, I will also implement
roundToNearestDayto fix #928 (comment).