Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed small typo in be-tarask locale #3130

Closed
wants to merge 6 commits into from
Closed

Conversation

nopears
Copy link
Contributor

@nopears nopears commented Jul 24, 2022

No description provided.

Copy link
Member

@fturmel fturmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The be-TAR directory was renamed to be-tarask after your original PR got merged, but this is adding the whole directory again. Can you remove these files and only apply the fixes to be-tarask?

Also, please run yarn locale-snapshots and commit the updated snapshot.md file for the locale.

@fturmel fturmel changed the title fixed small typo fixed small typo in be-tarask locale Jul 26, 2022
@leshakoss leshakoss added this to the v2.29.1 milestone Aug 11, 2022
@leshakoss
Copy link
Contributor

@nopears hi, could you please change the base branch for this PR from main to v2 and then rebase? I want to ship this as a patch

@nopears
Copy link
Contributor Author

nopears commented Aug 12, 2022

@leshakoss I made it, now the default branch in fork is v2, also opened pull request :)

@leshakoss
Copy link
Contributor

Cherry-picked this PR in #3160 and then released as v2.29.2: https://github.com/date-fns/date-fns/releases/tag/v2.29.2

@leshakoss leshakoss closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants