Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sv locale abbreviated months matcher #3135

Closed

Conversation

fturmel
Copy link
Member

@fturmel fturmel commented Jul 26, 2022

Closes #3133

This allows mars, juni and juli to be correctly parsed with the MMM (abbreviated month) token.

@leshakoss
Copy link
Contributor

@fturmel hi, could you please change the base branch for this PR from main to v2 and then rebase? I want to ship this as a patch

@fturmel fturmel changed the base branch from main to v2 August 11, 2022 12:21
@fturmel fturmel changed the base branch from v2 to main August 11, 2022 12:21
Copy link
Contributor

@leshakoss leshakoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fturmel
Copy link
Member Author

fturmel commented Aug 11, 2022

@leshakoss hold on, the rebase wasn't done yet on this PR

@fturmel fturmel marked this pull request as draft August 11, 2022 14:07
@leshakoss
Copy link
Contributor

Cherry-picked this PR in #3160 and then released as v2.29.2: https://github.com/date-fns/date-fns/releases/tag/v2.29.2

@leshakoss leshakoss closed this Aug 18, 2022
@fturmel fturmel deleted the PR/fix-sv-locale-abbrev-months-matcher branch August 19, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse 'd MMM y' date with SV locale returns invalid date
2 participants