Fix grammar in formatDistance of Ukrainian locale #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leshakoss
changed the title
|
@leshakoss looks good for me 👍 |
the same |
|
@leshakoss thank you so much for the PR, I would not hope someone will release a fix so fast. And sorry that I'm a bit late for this suggestion - I found it a bit confusing to have plural nominative form in singular genitive field for x distances though it fixes everything 😅. imho, rewriting declension function (which is almost identical to ru and be locales and caused the problem) is more approriate way here, so we don't change library approach. I know that that would make function more complicated, but could not leave it without a few words in comment at least. Thanks again for your work! |
patrickdevivo
added a commit
to mergestat/mergestat
that referenced
this pull request
Mar 7, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade date-fns
from 2.29.2 to 2.29.3.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **6 months ago**, on 2022-09-13.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>date-fns</b></summary>
<ul>
<li>
<b>2.29.3</b> - <a
href="https://snyk.io/redirect/github/date-fns/date-fns/releases/tag/v2.29.3">2022-09-13</a></br><p>This
release is prepared by our own <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/leshakoss/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/leshakoss">@ leshakoss</a>.</p>
<h3>Fixed</h3>
<ul>
<li>
<p><a href="https://snyk.io/redirect/github/date-fns/date-fns/pull/3175"
data-hovercard-type="pull_request"
data-hovercard-url="/date-fns/date-fns/pull/3175/hovercard">Fixed
Ukrainian (<code>uk</code>) locale grammar for
<code>formatDistance</code>.</a></p>
</li>
<li>
<p><a href="https://snyk.io/redirect/github/date-fns/date-fns/pull/3167"
data-hovercard-type="pull_request"
data-hovercard-url="/date-fns/date-fns/pull/3167/hovercard">Improved
browser compatibility by transforming the code with <code>@
babel/preset-env</code>.</a></p>
</li>
</ul>
</li>
<li>
<b>2.29.2</b> - <a
href="https://snyk.io/redirect/github/date-fns/date-fns/releases/tag/v2.29.2">2022-08-18</a></br><p>This
release is brought to you by <a class="user-mention notranslate"
data-hovercard-type="user" data-hovercard-url="/users/nopears/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nopears">@ nopears</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/vadimpopa/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/vadimpopa">@ vadimpopa</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leshakoss/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/leshakoss">@ leshakoss</a>.</p>
<h3>Fixed</h3>
<ul>
<li>
<p><a href="https://snyk.io/redirect/github/date-fns/date-fns/pull/3160"
data-hovercard-type="pull_request"
data-hovercard-url="/date-fns/date-fns/pull/3160/hovercard">Fixed
<code>sv</code> locale abbreviated months matcher.</a></p>
</li>
<li>
<p><a href="https://snyk.io/redirect/github/date-fns/date-fns/pull/3139"
data-hovercard-type="pull_request"
data-hovercard-url="/date-fns/date-fns/pull/3139/hovercard">Fixed
<code>uk</code> locale abbreviated months matcher.</a></p>
</li>
<li>
<p><a href="https://snyk.io/redirect/github/date-fns/date-fns/pull/3153"
data-hovercard-type="pull_request"
data-hovercard-url="/date-fns/date-fns/pull/3153/hovercard">Fixed a
breaking change in <code>intervalToDuration</code> by removing a
recently introduced RangeError.</a></p>
</li>
</ul>
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/date-fns/date-fns/releases">date-fns
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI2ZjdlODRkMS0zNTZmLTQzY2MtYjYzYy05MzEyZWYyZDcwMjAiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjZmN2U4NGQxLTM1NmYtNDNjYy1iNjNjLTkzMTJlZjJkNzAyMCJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/mergestat/project/e267d993-52da-4f6e-9de9-0012cd8b1835?utm_source=github&utm_medium=referral&page=upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mergestat/project/e267d993-52da-4f6e-9de9-0012cd8b1835/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mergestat/project/e267d993-52da-4f6e-9de9-0012cd8b1835/settings/integration?pkg=date-fns&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"6f7e84d1-356f-43cc-b63c-9312ef2d7020","prPublicId":"6f7e84d1-356f-43cc-b63c-9312ef2d7020","dependencies":[{"name":"date-fns","from":"2.29.2","to":"2.29.3"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/mergestat/project/e267d993-52da-4f6e-9de9-0012cd8b1835?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"e267d993-52da-4f6e-9de9-0012cd8b1835","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2022-09-13T12:36:12.348Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.