Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS] Long time formats for Czech do not include number of hours #3269

Merged
merged 3 commits into from
Jan 19, 2024
Merged

[CS] Long time formats for Czech do not include number of hours #3269

merged 3 commits into from
Jan 19, 2024

Conversation

TheKvikk
Copy link
Contributor

@TheKvikk TheKvikk commented Nov 4, 2022

Resolves #2921

Standardizes Czech number formats

  • Added "1" to all keys containing translation for one of something – one hour, one minute etc.

added one (1) to all x"one" keys
Copy link

@kvetis kvetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a Czech native speaker and this is correct.

@kvetis
Copy link

kvetis commented Mar 31, 2023

Can you please include the locale code in the title?

@TheKvikk TheKvikk changed the title Long time formats for Czech do not include number of hours [CS] Long time formats for Czech do not include number of hours Apr 1, 2023
@lhotamir
Copy link

Is there any way I can help with this PR being accepted? Our users keep reporting it and we really want ot solve this

@kossnocorp
Copy link
Member

I'm on it!

@TheKvikk
Copy link
Contributor Author

@kossnocorp tests should be fixed

@kossnocorp
Copy link
Member

@TheKvikk thank you a lot!

@kossnocorp kossnocorp merged commit 19ed910 into date-fns:main Jan 19, 2024
6 checks passed
@kossnocorp
Copy link
Member

Shipped with v3.3.0: https://github.com/date-fns/date-fns/releases/tag/v3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

Long time formats for Czech do not include number of hours
5 participants