Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kurdish language #3421

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Add Kurdish language #3421

merged 7 commits into from
Mar 11, 2024

Conversation

Revan99
Copy link
Contributor

@Revan99 Revan99 commented May 10, 2023

I added Kurdish CKB (Central Kurdish Branch)

@Revan99
Copy link
Contributor Author

Revan99 commented Jan 25, 2024

@kossnocorp can you check this one out?

@kossnocorp
Copy link
Member

@Revan99 sure, I'll review it when I have time

@fturmel
Copy link
Member

fturmel commented Jan 26, 2024

@Revan99 Do you need help converting this PR to be compatible with date-fns v3? There has been a few changes, mainly export/import and new Prettier rules. LMK. Once this is done, you can run npm run locale-snapshots to generate a proper snapshot.md file for the locale, and review it to validate the parser/formatter behavior.

I don't have first hand experience with this language, but did a bit of research and I think the right identifier for this locale would be ckb-IQ or ckb (IQ is the default region). ckb is a subset of kur and the identifier is supposed to be language-REGION, so ku-CKB is probably not right. The JSDocs in the index file could be updated to better identify the locale language and region as well.

https://en.wikipedia.org/wiki/Kurdish_languages
https://en.wikipedia.org/wiki/Sorani
https://icu4c-demos.unicode.org/icu-bin/locexp?_=ckb_IQ

@Revan99
Copy link
Contributor Author

Revan99 commented Jan 26, 2024

thank you @fturmel, I'll try to make it compatible with the new version and fix the other issues as well, and if I needed anything I'll let you know.
thanks again.

@kossnocorp
Copy link
Member

@fturmel thank you for offering help and doing the research. I think the ckb is the right code and we can drop the region code as both (IQ and IRQ) represent the same country - Iraq.

Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@kossnocorp kossnocorp merged commit 205e067 into date-fns:main Mar 11, 2024
7 checks passed
@kossnocorp
Copy link
Member

Shipped with date-fns@3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants