solution and changes for issue #3519 #3556
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue fix #3519. All tests were successfully passed.
For this issue, I made the following changes:
1. subDays/test.ts
2. addDays/test.ts
MINUTE
variable because it is not used now.3. addDays/index.ts
_date.setDate(_date.getDate() + amount)
to a new calculation based on milliseconds. (As was described in the issue description)4. addWeeks/index.ts
addDays()
function because this function has new calculation logic now. Changed its calculation for its old algorithm logic_date.setDate(_date.getDate() + amount * 7)
. In fact, there was only 1 line added.addDays()
, because it is not used now.5. nextMondays/tests.ts
nextTuesday()
,nextWednesday()
,nextThursday()
,nextFriday()
,nextSaturday()
,nextSunday()
.