Fix errors caused by d.mts files exporting only types #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2023
|
I shipped with the fix with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3616, #3615, #3588.
I still don't know what environmental settings cause this, but both smoke and "Are the types wrong?" are passing, and people reported that it helped, so I assume it should work.I shipped it asdate-fns@3.0.1-rc.1, so if you had this problem, I'd appreciate it if you could try it and tell me if it helped.Additionally, I'd love to have a minimal reproduction example so this doesn't happen in the future. Please add it to https://github.com/date-fns/date-fns/tree/main/examples and send a PR mentioning me.Sorry that the problem slipped. Making ESM work in all possible environments is a real nightmare.