Add Bengali locale (bn) for v2 #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touhidrahman
changed the title
touhidrahman
changed the title
|
Thanks for such a nice work. If possible please fix these spells: |
|
@sh4hids Thank you for your review comment. AFAIK, bangla Academy prefers ন over ণ nowadays. And with বেশি, I agree with you as Bangla Academy is trying to move from ী to ি as much as possible. However IMO this is a minor issue, let's wait for the merge first. Or you can go ahead and change the বেশী to বেশি। |
kossnocorp
approved these changes
Sep 18, 2018
|
I'm going to go through pending locales and then release a new v2 version. Thank you again, you guys are great! |
|
I've just published a new version with this locale Thank you again for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836
This PR will introduce Bengali (bn) locale in date-fns.