Add Persian language with code fa-IR #903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kossnocorp
requested changes
Oct 4, 2018
| import assert from 'power-assert' | ||
| import formatDistance from '.' | ||
|
|
||
| describe('en-US locale > formatDistance', function () { |
There was a problem hiding this comment.
Please update the description
| assert(result === 'in half a minute') | ||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
These tests aren't implemented.
| // Note: in English, the names of days of the week and months are capitalized. | ||
| // If you are making a new locale based on this one, check if the same is true for the language you're working on. | ||
| // Generally, formatted dates should look like they are in the middle of a sentence, | ||
| // e.g. in Spanish language the weekdays and months should be in the lowercase. |
There was a problem hiding this comment.
Please remove the comment as it's not relevant anymore.
| // var unit = String(options.unit) | ||
| // | ||
| // where `unit` can be 'year', 'quarter', 'month', 'week', 'date', 'dayOfYear', | ||
| // 'day', 'hour', 'minute', 'second' |
There was a problem hiding this comment.
Please remove the comment, it's not relevant anymore.
| * @iso-639-2 eng | ||
| * @author Sasha Koss [@kossnocorp]{@link https://github.com/kossnocorp} | ||
| * @author Lesha Koss [@leshakoss]{@link https://github.com/leshakoss} | ||
| */ |
| import formatRelative from '../../formatRelative' | ||
| import parse from '../../parse' | ||
|
|
||
| describe('en-US locale', function () { |
| assert.deepEqual(result, new Date(1986, 3 /* Apr */, 4, 1, 2, 3)) | ||
| }) | ||
| }) | ||
| }) |
|
@MahdiMajidzadeh Ping. |
|
Closed by #1113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.