Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user config type #626

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

homostellaris
Copy link
Contributor

@homostellaris homostellaris commented Jan 31, 2024

Adds a type for the user config which makes it easier to know what's possible when setting up your own Flowershow instance.

Closes #625

Copy link

vercel bot commented Jan 31, 2024

@homostellaris is attempting to deploy a commit to the Datopian Team on Vercel.

A member of the Team first needs to authorize it.

@mohamedsalem401
Copy link
Member

@homostellaris
Thanks a lot for this.🙌 I've reviewed and tested this.

I think it's good to be merged.

@mohamedsalem401
Copy link
Member

@homostellaris
The only thing left would be to move this to the right repo, which is https://github.com/datopian/portaljs/blob/main/packages/core/src/config/default.ts, as I don't think those changes should be in Flowershow.

@homostellaris
Copy link
Contributor Author

homostellaris commented Feb 16, 2024

@mohamedsalem401 I don't think that would make sense as it's describing the flowershow config which is different to the portal config. You'll notice in siteConfig.ts that where appropriate the portal config types are being referenced but you can also see the additional properties that are specific to flowershow.

If you're worried about the failing build I think that's just due to some upstream changes that I need to include in the config.

@homostellaris
Copy link
Contributor Author

@mohamedsalem401 the above commit should fix the build error in Vercel.

@mohamedsalem401 mohamedsalem401 merged commit 9d3da90 into datopian:main Feb 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User config has no type
2 participants