Update content on image update #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davestewart
force-pushed
the
0030-update-docs-on-image-update
branch
7 times, most recently
from
b7c485f
to
313e266
Compare
davestewart
force-pushed
the
0030-update-docs-on-image-update
branch
from
313e266
to
55ff83e
Compare
davestewart
force-pushed
the
0030-update-docs-on-image-update
branch
from
0463c11
to
755da66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue of image resizing not updating values in cached content.
Currently, if an image is resized, it will trigger a live-reload, but the proportions could be wrong.
Now, when images are first processed, any content they are included in is registered, and when the image is updated in future, the related content is scanned and image sizes manually changed.
This PR also lays the groundwork for #18 where pre-cached content could be tested for relative paths and written back to if any are found.
Note that the work here is waiting for the following PR to be merged and released in Nuxt Content core: