Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add max depth limit and max edges limit #51

Closed
wants to merge 5 commits into from
Closed

fix: add max depth limit and max edges limit #51

wants to merge 5 commits into from

Conversation

matus-sabo
Copy link
Contributor

@matus-sabo matus-sabo commented Apr 15, 2021

fix for #pinojs/pino#990

  • new feature to handle big deep objects - when limit reached object will be replaced with [...]
  • new optional parameter options
  • set default limits to
    • depthLimit 10 - how deep parse input object
    • edgesLimit 20 - how deep parse object keys or array items
  • test for optional parameter options
  • updated changelog & readme
  • bump minor version to 2.1.0

Copy link
Contributor

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • update PR description with an explanation of how this works and rationale
  • write tests
  • update docs

@ahmedsuleman
Copy link

Hi!

I ran into same problem as described in https://githubmemory.com/repo/pinojs/pino/issues/990?page=2.
I am using winston-cloudwatch (2.3.2) that requires/uses fast-safe-stringify (2.0.7).

@lamanabie is the fix available in version 2.1.0! As I can see, the latest available version is 2.0.8.
https://www.npmjs.com/package/fast-safe-stringify

Regards,
Suleman

@simoneb
Copy link
Contributor

simoneb commented Sep 6, 2021

@ahmedsuleman because this PR has not been merged, the fix is not available in any published version of the package.

@ahmedsuleman
Copy link

fix for #pinojs/pino#990

  • new feature to handle big deep objects - when limit reached object will be replaced with [...]

  • new optional parameter options

  • set default limits to

    • depthLimit 10 - how deep parse input object
    • edgesLimit 20 - how deep parse object keys or array items
  • test for optional parameter options

  • updated changelog & readme

  • bump minor version to 2.1.0

@ahmedsuleman because this PR has not been merged, the fix is not available in any published version of the package.

Ah ok! Looking forward to it :)

@mcollina mcollina closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants