Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to select more workspaces for deletion #378

Closed
nkkko opened this issue Apr 11, 2024 · 14 comments · Fixed by #636
Closed

Provide ability to select more workspaces for deletion #378

nkkko opened this issue Apr 11, 2024 · 14 comments · Fixed by #636
Labels

Comments

@nkkko
Copy link
Member

nkkko commented Apr 11, 2024

Is your feature request related to a problem? Please describe.
When creating multiple workspaces, such as for reviewing pull requests, users should be able to select and delete multiple workspaces simultaneously. Now it is only possible to delete one by one.

Describe the solution you'd like
The interface should also offer the option to select multiple workspaces for removal.

@nkkko nkkko added the enhancement New feature or request label Apr 11, 2024
@vedranjukic
Copy link
Member

We could allow multiple workspace name attributes on workspace delete command.

@Tpuljak
Copy link
Member

Tpuljak commented Apr 11, 2024

/bounty $20

Copy link

algora-pbc bot commented Apr 11, 2024

💎 $20 bounty • Daytona

Steps to solve:

  1. Start working: Comment /attempt #378 with your implementation plan
  2. Submit work: Create a pull request including /claim #378 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

If no one is assigned to the issue, feel free to tackle it, without confirmation from us, after registering your attempt. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

Thank you for contributing to daytonaio/daytona!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @feliciien Apr 15, 2024, 2:46:59 PM WIP
🟢 @shashank40 May 4, 2024, 10:16:28 AM #636

@ezhil56x
Copy link
Contributor

@Tpuljak

I would like to work on this. I hope we should support #378 (comment) (passing multiple workspace name in the command) and #378 (comment) (interface for selecting multiple workspace). I have a rough idea of how can we implement this. I have added a diagram below. Is this how you want it to be implemented?

Diagram Image

@Tpuljak
Copy link
Member

Tpuljak commented Apr 12, 2024

@ezhil56x that's exactly right. Additionally, multiple workspace should be selectable on the daytona start/stop commands as well.

@ezhil56x
Copy link
Contributor

Is selecting multiple workspaces for start/stop included in this issue. Or different issue will be created?

@Tpuljak
Copy link
Member

Tpuljak commented Apr 12, 2024

Is selecting multiple workspaces for start/stop included in this issue. Or different issue will be created?

I think we should include that in solving this issue as well. The code changes in the 3 methods will be almost identical.

@feliciien
Copy link

feliciien commented Apr 15, 2024

/attempt #378

Algora profile Completed bounties Tech Active attempts Options
@feliciien 5 bounties from 1 project
MDX, Rust,
JavaScript & more
Cancel attempt

@shashank40
Copy link
Contributor

Hey @Tpuljak Can you update some readme/guide me to local setup?
I want to have a local setup in order to contribute to the issue.

@Tpuljak
Copy link
Member

Tpuljak commented Apr 24, 2024

Hi @shashank40,

Thanks for your interest in contributing! The easiest way to get set up is to clone Daytona, open it in VS Code and then open it inside a Dev Container. That will get you set up completely and allow you to run daytona commands in development.

You can find more info about Dev Containers here.

@Tpuljak
Copy link
Member

Tpuljak commented Apr 27, 2024

Note to contributors: As part of this issue, we should allow the user to pass multiple workspace names to the remove command (e.g. daytona rm wrk1 wrk2 ...).

shashank40 added a commit to shashank40/daytona that referenced this issue May 4, 2024
shashank40 added a commit to shashank40/daytona that referenced this issue May 4, 2024
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
@shashank40
Copy link
Contributor

shashank40 commented May 4, 2024

/attempt #378

Hi @Tpuljak
I am attaching a PR for the same.

The PR also has a small video attached in the description to show how the feature works.

Algora profile Completed bounties Tech Active attempts Options
@shashank40 1 bounty from 1 project
Python, TypeScript,
JavaScript
Cancel attempt

shashank40 added a commit to shashank40/daytona that referenced this issue Jun 4, 2024
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
Copy link

algora-pbc bot commented Jun 4, 2024

💡 @shashank40 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

shashank40 added a commit to shashank40/daytona that referenced this issue Jun 5, 2024
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Resolved comments

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
shashank40 added a commit to shashank40/daytona that referenced this issue Jun 6, 2024
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Resolved comments

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
shashank40 added a commit to shashank40/daytona that referenced this issue Jun 6, 2024
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Resolved comments

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
shashank40 added a commit to shashank40/daytona that referenced this issue Jun 6, 2024
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Resolved comments

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
shashank40 added a commit to shashank40/daytona that referenced this issue Jun 6, 2024
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Resolved comments

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
shashank40 added a commit to shashank40/daytona that referenced this issue Jun 6, 2024
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Resolved comments

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
shashank40 added a commit to shashank40/daytona that referenced this issue Jun 6, 2024
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Resolved comments

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

Adding single workspace deleteion back

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>

changed font

Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
Copy link

algora-pbc bot commented Jun 6, 2024

🎉🎈 @shashank40 has been awarded $20! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants