FEAT: Ability to delete multiple workspaces. Issue #378 #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shashank40 <shashanktiwari40@gmail.com>
shashank40
force-pushed
the
shashank40/issue#378/delete_multiple_workspace_feature
branch
from
0548f75
to
2a07be9
Compare
|
Hi @shashank40 thank you for the pull request. This solutions gets the work done, however we were more interested in an approach that customizes the component directly like this example to have the workspaces be "marked" for deletion all in the same selection prompt and then submitted once you hit enter. Pressing a key (e.g. space) would mark/unmark the workspace by adding/removing a "(x) " symbol or something similar. Pressing enter would exit the view and start deleting the marked workspaces one by one. Could you update your changes to reflect this kind of functionality? I will move the PR to drafts for now |
idagelic
force-pushed
the
shashank40/issue#378/delete_multiple_workspace_feature
branch
from
de3bf69
to
2a07be9
Compare
|
Closing this PR as we received no response for 3 weeks. Feel free to reopen it when it's ready for review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Description
/claim #378
Please include a summary of the change or the feature being introduced. Include relevant motivation and context. List any dependencies that are required for this change.
Type of Change
Checklist
Related Issue(s)
This PR addresses issue #378
Screen Recording.
screen-recording-2024-05-04-at-32724-pm_5BPiQZmd.mp4
Notes
The video shows how we can delete multiple workspaces doing 2 things