fix: headscale grpc regression #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpuljak
force-pushed
the
grpc-regression
branch
from
a41abee
to
0c68d45
Compare
idagelic
approved these changes
Apr 26, 2024
Signed-off-by: Toma Puljak <toma.puljak@hotmail.com>
Tpuljak
force-pushed
the
grpc-regression
branch
from
0c68d45
to
ce687e1
Compare
vedranjukic
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Headscale GRPC regression
Description
In #433, we updated the GRPC package to 1.63.0 which marked
DialContextas deprecated and suggested to useNewClientinstead. Unfortunately,NewClientdoes not work for us currently and would require more investigation into how to migrate successfully.In the meantime, this PR reverts to
DialContext.Type of Change
Checklist
Notes
More info on how to migrate should be available here grpc/grpc-go#7049.