fix: multi-project create not working #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunrajput
force-pushed
the
fix/multi-project-create
branch
from
41c0430
to
4159a1b
Compare
Tpuljak
requested changes
May 17, 2024
There was a problem hiding this comment.
Approved before, but I found an issue.
When you use daytona create --multi-project while having a git provider, the second repo (and all after that) are ignored. That's also what the linter is throwing.
The if-else statement was there to ensure this. If the user does not provide the repo through the TUI (the user selects the manual input) then you need to show them the manual url input form, otherwise, just the "Add more" switch.
My screenshot was taken after I selected a repo from the TUI.
Signed-off-by: tarunrajput <tarunrajput1337@gmail.com>
tarunrajput
force-pushed
the
fix/multi-project-create
branch
from
4159a1b
to
6cdad61
Compare
|
@Tpuljak, it should be fixed now |
Tpuljak
approved these changes
May 17, 2024
2 tasks
idagelic
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix
--multi-projectcreate not workingRelated Issue(s)
Closes #577
/claim #577