Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage.py is broken on python3.8, upgrade to the latest version. #838

Merged
merged 2 commits into from Apr 17, 2020

Conversation

laixintao
Copy link
Member

@laixintao laixintao commented Mar 18, 2020

Description

see dbcli/pgcli#1158

nedbat/coveragepy#714

Checklist

  • I've added this contribution to the changelog.md.
  • I've added my name to the AUTHORS file (or it's already there).

@laixintao
Copy link
Member Author

@laixintao
Copy link
Member Author

Can we get this merged :)

@codecov-io
Copy link

codecov-io commented Apr 16, 2020

Codecov Report

Merging #838 into master will increase coverage by 26.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #838       +/-   ##
===========================================
+ Coverage   53.64%   79.82%   +26.18%     
===========================================
  Files          25       23        -2     
  Lines        3626     1750     -1876     
===========================================
- Hits         1945     1397      -548     
+ Misses       1681      353     -1328     
Impacted Files Coverage Δ
mycli/main.py
mycli/__init__.py
mycli/packages/tabular_output/sql_format.py 100.00% <0.00%> (+2.32%) ⬆️
mycli/packages/special/delimitercommand.py 90.90% <0.00%> (+3.95%) ⬆️
mycli/packages/special/dbcommands.py 13.39% <0.00%> (+6.44%) ⬆️
mycli/config.py 88.46% <0.00%> (+10.75%) ⬆️
mycli/clitoolbar.py 33.33% <0.00%> (+16.31%) ⬆️
mycli/completion_refresher.py 95.45% <0.00%> (+18.62%) ⬆️
mycli/clistyle.py 64.00% <0.00%> (+22.44%) ⬆️
mycli/packages/special/iocommands.py 90.75% <0.00%> (+23.25%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19bea71...6eb0caa. Read the comment docs.

@amjith amjith merged commit efc202f into dbcli:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants