Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing default interval for Stream usage #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zygos
Copy link

@zygos zygos commented Mar 10, 2022

I stumbled upon an issue where pino-cloudwatch as a Writable Stream would result in no reported events. That's because the default interval is only set when running through bin/pino-cloudwatch.js and not when it's directly imported. undefined interval would result in a failed this.interval > 0 check in chunky-stream resulting in skipped setTimeout and thus no reported events. Adding a default value fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant