addition: check_snapshot_name_contract #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added entry for check-snapshot-name-contract
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
=========================================
+ Coverage 0 97.95% +97.95%
=========================================
Files 0 51 +51
Lines 0 2497 +2497
Branches 0 330 +330
=========================================
+ Hits 0 2446 +2446
- Misses 0 32 +32
- Partials 0 19 +19 ☔ View full report in Codecov by Sentry. |
|
Hey @ryancollingwood, could you please resolve conflicts? We've modified snapshot obtention and some logic on the latest PRs. Later this week we'll release a new version, and your PR could become part of it. |
|
@BAntonellini resolved the conflict, although there are failing tests for |
|
@ryancollingwood could you merge main and try to fix such tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_snapshot_name_contractis similar in behaviour tocheck_model_name_contractImpacts to existing code
get_snapshots(indbt_checkpoint/utils.py) now returns a generator ofModel, previously it returned a list of strings detailing the filename of snapshots. In order to evaluate the name for the snapshot additional information is needed. This has resulted in a change todbt_checkpoint/check_model_has_properties_file.py