Issue 219: extend check_model_has_tests_by_name exclude argument to committed files #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding exclude regex pattern to committed files
|
Hi @SantiASC, thank you for your contribution. Could you please review and adapt the tests that are failing? |
@BAntonellini i believe this is @SantiASC first pr/open source contribution. is there any guidance you could provide on how he can troubleshoot these failing tests? we work on the same team and are using the package today, would both be happy to contribute more as we get into things but there's a disconnect on how to make sure we do it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Description of the issue can be found in issue 219