Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve nicely formatted timeout exception #1187

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Apr 19, 2024

Add descriptive error message on query timeout

It appears that in 3.21.0 of python-bigquery the error handling was changed and the descriptive error message was dropped. This message is useful for users and we rely on it for testing purposes.

Likely PR that introduced the change: googleapis/python-bigquery#1900

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Apr 19, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Apr 19, 2024
@colin-rogers-dbt colin-rogers-dbt merged commit b62ce74 into main Apr 19, 2024
28 of 29 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the preserveDescriptiveTimeoutException branch April 19, 2024 16:32
@colin-rogers-dbt colin-rogers-dbt added the backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch label Apr 23, 2024
Copy link
Contributor

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-1187-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b62ce7469a47de4e1f526fc551817b3e0919ddb2
# Push it to GitHub
git push --set-upstream origin backport-1187-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-1187-to-1.7.latest.

@colin-rogers-dbt colin-rogers-dbt added the backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch label Apr 23, 2024
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-1187-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b62ce7469a47de4e1f526fc551817b3e0919ddb2
# Push it to GitHub
git push --set-upstream origin backport-1187-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-1187-to-1.6.latest.

colin-rogers-dbt added a commit that referenced this pull request Apr 24, 2024
* use dynamic schema in test_grant_access_to.py

* use dynamic schema in test_grant_access_to.py

* revert setup

* Add descriptive error message on query timeout

* Add descriptive error message on query timeout

(cherry picked from commit b62ce74)
colin-rogers-dbt added a commit that referenced this pull request Apr 24, 2024
* use dynamic schema in test_grant_access_to.py

* use dynamic schema in test_grant_access_to.py

* revert setup

* Add descriptive error message on query timeout

* Add descriptive error message on query timeout

(cherry picked from commit b62ce74)
colin-rogers-dbt added a commit that referenced this pull request Apr 24, 2024
* use dynamic schema in test_grant_access_to.py

* use dynamic schema in test_grant_access_to.py

* revert setup

* Add descriptive error message on query timeout

* Add descriptive error message on query timeout

(cherry picked from commit b62ce74)
colin-rogers-dbt added a commit that referenced this pull request Apr 24, 2024
* use dynamic schema in test_grant_access_to.py

* use dynamic schema in test_grant_access_to.py

* revert setup

* Add descriptive error message on query timeout

* Add descriptive error message on query timeout

(cherry picked from commit b62ce74)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6.latest Tag for PR to be backported to the 1.6.latest branch backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants