Update to clap v4 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was expecting this to be much more difficult than it turned out to be. Back when 3.2.2 first was released, we hit a bunch of warnings, as described in this clap issue: clap-rs/clap#3822. Clap moved those warnings behind the "deprecated" feature flag in v3.2.3. I was expecting to need to address the warnings I saw when updating to clap 3.2.2 before updating to v4, however those warnings seem to no longer occur. Perhaps they were accidentally addressed as we generally updated our CLI based on online docs? Or perhaps something changed on the clap end?
Regardless, updating clap and clap_mangen in concert, and fixing the one
_/-confusion in the commit seems to have everything working functionally as far as I can tell.As a future note, the clap migrating instructions suggest using the "trycmd" crate to do cli testing. That could be a good future enhancement, but is more than I wanted to get into in this PR. Currently our testing focused on the cascade library calls, and casc automated testing is extremely minimal (first casc specific test is in this PR).