perf(artifacts): compile appliationsRegex once instead of on each use

dbyron-sf · Mar 3, 2024 · 3330260 · 3330260
1 parent b18f1b1
commit 3330260
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...ain/java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorer.java b/...ain/java/com/netflix/spinnaker/kork/artifacts/artifactstore/s3/S3ArtifactStoreStorer.java
@@ -48,7 +48,7 @@ public class S3ArtifactStoreStorer implements ArtifactStoreStorer {
   private final S3Client s3Client;
   private final String bucket;
   private final ArtifactStoreURIBuilder uriBuilder;
-  private final String applicationsRegex;
+  private final Pattern applicationsPattern;
 
   public S3ArtifactStoreStorer(
       S3Client s3Client,
@@ -58,7 +58,8 @@ public S3ArtifactStoreStorer(
     this.s3Client = s3Client;
     this.bucket = bucket;
     this.uriBuilder = uriBuilder;
-    this.applicationsRegex = applicationsRegex;
+    this.applicationsPattern =
+        (applicationsRegex != null) ? Pattern.compile(applicationsRegex) : null;
   }
 
   /**
@@ -76,7 +77,7 @@ public Artifact store(Artifact artifact) {
       return artifact;
     }
 
-    if (applicationsRegex != null && !Pattern.matches(applicationsRegex, application)) {
+    if (applicationsPattern != null && !applicationsPattern.matcher(application).matches()) {
       return artifact;
     }