add round contributions #560
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metafraction
force-pushed
the
round-contributions
branch
from
99dead4
to
f3955db
Compare
metafraction
force-pushed
the
round-contributions
branch
from
f3955db
to
150fee8
Compare
metafraction
force-pushed
the
round-contributions
branch
from
150fee8
to
7484325
Compare
apbendi
requested changes
Dec 3, 2021
There was a problem hiding this comment.
hey @mk1r, just checked this out locally, and while it looks and works, it seems there was confusion about the actual requirements.
What it seems you built is "The contributions to grants in this grant round." What we were looking for was "The contributions to this Round's matching pool", i.e. those denoted by this event: https://github.com/dcgtc/dgrants/blob/main/contracts/contracts/GrantRound.sol#L95
|
@apbendi ah I see, okay let's discuss this in standup - do we still want the feature in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new feature
