Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: install deb.sury.org key from debsuryorg-archive-keyring, fixes #6143 #6180

Merged
merged 1 commit into from
May 14, 2024

Conversation

stasadev
Copy link
Member

The Issue

How This PR Solves The Issue

Uses the debsuryorg-archive-keyring package for PHP keyring.

Manual Testing Instructions

$ ddev exec dpkg -L debsuryorg-archive-keyring
/.
/etc
/etc/apt
/etc/apt/trusted.gpg.d
/etc/apt/trusted.gpg.d/debsuryorg-archive.gpg
/usr
/usr/share
/usr/share/doc
/usr/share/doc/debsuryorg-archive-keyring
/usr/share/doc/debsuryorg-archive-keyring/changelog.gz
/usr/share/doc/debsuryorg-archive-keyring/copyright
/usr/share/keyrings
/usr/share/keyrings/deb.sury.org-apache2.gpg
/usr/share/keyrings/deb.sury.org-bind-dev.gpg
/usr/share/keyrings/deb.sury.org-bind-esv.gpg
/usr/share/keyrings/deb.sury.org-bind.gpg
/usr/share/keyrings/deb.sury.org-nginx-mainline.gpg
/usr/share/keyrings/deb.sury.org-nginx.gpg
/usr/share/keyrings/deb.sury.org-php.gpg

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner May 13, 2024 19:51
@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance labels May 13, 2024
Copy link

github-actions bot commented May 13, 2024

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems perfect to me. If it builds the image OK, it's good to go.

@rfay
Copy link
Member

rfay commented May 13, 2024

Container tests for this have already succeeded, IMO go ahead and pull when you are ready.

@stasadev stasadev merged commit e4146a4 into ddev:master May 14, 2024
21 of 23 checks passed
@stasadev stasadev deleted the 20240513_stasadev_debsuryorg branch May 14, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants