Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Python3 and masOS Monterey #13

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

otsec
Copy link

@otsec otsec commented Aug 2, 2022

As guys already noticed here #12 , in recent macOS update this workflow has been broken because Python 2 was removed.

I tried to fix it and looks like succeed.

  • A huge thanks to @mesozoic for this PR Python 3 support [WIP] alfred-workflow#184. I used his code to update Workflow lib.

  • Current version has an extra code to work with clipboard privately. It requires special lib, that were shipped with macos but not anymore. I decided to switch to Alfred's clipboard functionality. It now has a checkbox for private copy. I think it means, that old Alfred versions are not supported anymore.

  • I also decided to remove Notify app that were shipped with workflow and switch to Alfred's notifications.

  • I switch python in path to /usr/lib/python3, so support of old macOS versions without Python 3 can result be dropped as well.

Direct link to updated workflow
https://github.com/otsec/alfred-pwgen/raw/python3/Password-Generator-3.0.0-alpha-1.alfredworkflow

@djp3
Copy link

djp3 commented Aug 3, 2022

Thank you!

@aaronk1
Copy link

aaronk1 commented Aug 4, 2022

Thanks! Confirmed working here.

@virtualize
Copy link

virtualize commented Aug 19, 2022

Confirming the works as expected. Thanks a lot for the rewrite!

@deanishe WDYT about merging this and releasing a new major version?

@jeremib
Copy link

jeremib commented Sep 9, 2022

Thanks for this!

@huangkengwei
Copy link

Thanks a lot!

@stacksjb
Copy link

Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants