Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use screen name instead of IP address to announce server through zeroconf #1286

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use screen name instead of IP address to announce server through zeroconf #1286

wants to merge 2 commits into from

Conversation

nicerloop
Copy link

Same way it is done for client.

See symless@f2cc582 from myself.

@nicerloop
Copy link
Author

symless#6679

@p12tic
Copy link
Member

p12tic commented Nov 1, 2021

Code looks good to me.

p12tic
p12tic requested changes Nov 1, 2021
View reviewed changes
Copy link
Member

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a release note in the doc/newsfragments directory of the repository.

@ghost ghost mentioned this pull request Nov 10, 2021
Merged
@nicerloop nicerloop requested a review from p12tic December 2, 2021 15:43
@mirh
Copy link

mirh commented Feb 25, 2022

It's especially stupid when "auto config" greys out "server IP"
And yet it's still actually trying to ping that specific one that was last inserted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p12tic p12tic Awaiting requested review from p12tic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicerloop @p12tic @mirh