Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Use step summary, labeled distinctly #33

Merged
merged 1 commit into from Jun 3, 2022
Merged

Feat: Use step summary, labeled distinctly #33

merged 1 commit into from Jun 3, 2022

Conversation

mchenryc
Copy link
Contributor

@mchenryc mchenryc commented Jun 1, 2022

This PR changes the "summary" mechanism to post overall results of a workflow to use the new Step Summaries, solving two problems I have run into:

  1. Multiple Cucumber tasks (due to job matrix, or other) use the same title on the "summary annotation" so it is difficult to tell from the Workflow summary which results were for which cucumber run
  2. The summary annotation has an unnecessary "link to file position"

Instead of a "summary annotation" this adds much same information in a step summary, using the title of the cucumber step, which is displayed nicely in the overall workflow summary page. Because it uses markdown, future changes can make this much more pretty and/or informative.

Note this builds directly off the on the repository cleanup and distribution mechanism in #32. See commit d24a4c2 for actual changes.

image

@deblockt
Copy link
Owner

deblockt commented Jun 3, 2022

Hi, great feature 🎉
I merge the other PR #32 , can you resolve conflicts to be able to merge this PR?

Thanks ❤️

@mchenryc
Copy link
Contributor Author

mchenryc commented Jun 3, 2022

Should be good to go. Permissions on GH Actions repos are a nuisance. Thanks for accepting!

@deblockt deblockt self-assigned this Jun 3, 2022
@deblockt deblockt merged commit 705e822 into deblockt:master Jun 3, 2022
@mchenryc
Copy link
Contributor Author

mchenryc commented Jun 9, 2022

@deblockt with this merged, is it worth publishing a 1.9 release?

@deblockt
Copy link
Owner

deblockt commented Jun 9, 2022

@mchenryc done sorry for the delay

@mchenryc mchenryc deleted the feat/use-step-summary branch June 15, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants