fix: don't shrink loop bounds by assuming the body is at the end #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes decaffeinate/decaffeinate#333 Fixes decaffeinate/decaffeinate#502 The code to fix CoffeeScript location data was incorrectly assuming that the last node of a loop is the loop body, but that isn't true in postfix loops, so it was causing the end location to be artificially early. Probably, the ideal behavior (assuming location data actually needs to be fixed here) is to take the max of all nodes, but that didn't seem trivial. Instead, an easy fix is to just do the same thing we do for the `if` case: just use the body to extend the bounds if necessary, but never shrink it. This also seems more robust in general, probably. At the very least, it's really simple and doesn't break any decaffeinate tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes decaffeinate/decaffeinate#333
Fixes decaffeinate/decaffeinate#502
The code to fix CoffeeScript location data was incorrectly assuming that the
last node of a loop is the loop body, but that isn't true in postfix loops, so
it was causing the end location to be artificially early. Probably, the ideal
behavior (assuming location data actually needs to be fixed here) is to take the
max of all nodes, but that didn't seem trivial. Instead, an easy fix is to just
do the same thing we do for the
ifcase: just use the body to extend thebounds if necessary, but never shrink it. This also seems more robust in
general, probably. At the very least, it's really simple and doesn't break any
decaffeinate tests.