fix: silence magic-string warnings and update usage #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magic-string 0.17.0 deprecated insertLeft and insertRight in favor of more precise prepend/append names. See this issue for a discussion on that: Rich-Harris/magic-string#109 To silence that warning, this commit moves the code to the new API, which was pretty easy because there are only a few call sites. I also cleaned up that part of `NodePatcher`, which didn't make a lot of sense. Now, instead of `NodePatcher.insert` calling `NodePatcher.insertRight` calling `MagicString.insertLeft` and `NodePatcher.insertLeft` being unused, we just have `NodePatcher.insert` calling `MagicString.appendLeft`. At least for now, I think it's best to always use the same insert method so that inserts go in order. I also changed insertRight to appendRight in one case because it probably makes more sense anyway and the tests pass.
eventualbuddha
approved these changes
Nov 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
magic-string 0.17.0 deprecated insertLeft and insertRight in favor of more
precise prepend/append names. See this issue for a discussion on that:
Rich-Harris/magic-string#109
To silence that warning, this commit moves the code to the new API, which was
pretty easy because there are only a few call sites.
I also cleaned up that part of
NodePatcher, which didn't make a lot of sense.Now, instead of
NodePatcher.insertcallingNodePatcher.insertRightcallingMagicString.insertLeftandNodePatcher.insertLeftbeing unused, we justhave
NodePatcher.insertcallingMagicString.appendLeft. At least for now, Ithink it's best to always use the same insert method so that inserts go in
order.
I also changed insertRight to appendRight in one case because it probably makes
more sense anyway and the tests pass.