ftguess: Handle error when [Content_Types].xml is not present. #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I came across some files where this XML was named [Content_Types].xmla. It's strange suffix, MS Word does not open it and ftguess crashes with KeyError.
|
I have never seen such files. If MS Word refuses to open them, it means they are malformed. Is it possible to share those files with me so that I have a look and reproduce the issue? (either here with a password-protected zip, or a link to online sandboxes if samples are public) |
|
Mail sent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across some files where this XML was named
[Content_Types].xmla. It's strange suffix, MS Word does not open it andftguesscrashes withKeyError.Have you ever seen such files? The other option would be to support analysis even for
xmlacontent types. It's up to you.I'm mostly interested in non-crashing
olevbaso this is a quickfix. If you think we should handle such files differently, let me know or feel free to implement it yourself and close this PR :)