Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes to support profile privacy options #11036

Draft
wants to merge 34 commits into
base: develop
Choose a base branch
from

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented Jun 14, 2023

🎩 What? Why?

In order to support profile privacy in the external module we are building right now, we will add any proposed API changes to this PR.

This is the second iteration after the following findings:

  1. It would be beneficial also for the core to consider the user profile publicity based on if the user has accepted the terms of service which might be a requirement for displaying their profile on the website when they first sign in to the platform.
  2. It seems a better approach to consider the profile publicity only in places where we would actually display the user data publicly on the website. This approach seems to require changes in less modules (including 3rd party modules) making it more convenient overall.

This is still work in progress but I will open this already now so that we can continue on the same PR.

📌 Related Issues

Testing

TBD

@alecslupu
Copy link
Contributor

@ahukkanen maybe you could merge this with the decidim develop as well? I see there are many files that seems to be added, but they are already in develop.

@alecslupu
Copy link
Contributor

@ahukkanen maybe you could merge this with the decidim develop as well? I see there are many files that seems to be added, but they are already in develop.

nevermind! You already updated it

@andreslucena
Copy link
Member

@ahukkanen I'm checking out old PRs and found this one. Are you planning on retaking this?

@ahukkanen
Copy link
Contributor Author

@andreslucena Definitely this is very important for us and I will finish this as soon as we can get feedback on the remaining issue, i.e. discussion #11057.

There are few failing specs because of this open issue and I don't know how to handle that before we get feedback from @decidim/product on what kind of approach to take with the groups visibility.

Other than that, this is already pretty much done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants