Remove invalid upload files #11851
Remove invalid upload files #11851
Conversation
alecslupu
added
target: developer-experience
type: fix
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Tried it locally and it works well! Code-wise it's 👌🏽 👏🏽 👏🏽
I'll wait for @ahukkanen review too as he understands much better the ActiveStorage API and implications just in case.
alecslupu
dismissed stale reviews from andreslucena and github-actions
via
5d6ab94
…ent-validation-cleanup
…ent-validation-cleanup
…ent-validation-cleanup
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ent-validation-cleanup
…UnattachedBlobJob
…of difference just to be sure
it prevents access by unauthenticated users it validates by the allowed mime types in system defined for participants in case the current_user is a normal participant it validates by the allowed mime types in system defined for admins in case the current_user is an admin
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
decidim-core/app/controllers/decidim/direct_uploads_controller.rb
Outdated
Show resolved
Hide resolved
decidim-core/app/controllers/decidim/direct_uploads_controller.rb
Outdated
Show resolved
Hide resolved
decidim-core/app/controllers/decidim/direct_uploads_controller.rb
Outdated
Show resolved
Hide resolved
decidim-core/app/controllers/decidim/direct_uploads_controller.rb
Outdated
Show resolved
Hide resolved
| private | ||
|
|
||
| def remove_invalid_file | ||
| blob = ActiveStorage::Blob.find_signed(@form.blob) |
There was a problem hiding this comment.
I think we should change the type of the :blob attribute on the form itself to Decidim::Attributes::Blob.
It does exactly this.
This is probably an oversight in the previous implementation (or the attribute didn't exist back then).
There was a problem hiding this comment.
@alecslupu Is there some problem implementing this change? I was just wondering because the other changes seem to be already implemented, just this one is still open.
There was a problem hiding this comment.
@ahukkanen, there is no issue. Just this PR has not been under my attention lately. also the implementation needs to be changed so that the upload flow to handle the validation as well.
There was a problem hiding this comment.
OK thanks and noted. Let me know if this still needs my attention.
decidim-core/app/controllers/decidim/direct_uploads_controller.rb
Outdated
Show resolved
Hide resolved
🎩 What? Why?
This PR will remove any file uploaded, that is invalid ( either format or size )
Testing
./development_app/storage)